Comfy-Org / Comfy-Org/ComfyUI

stable audio broken with partial loading (indicative of slightly bigger bug)

Open
#11,855 3 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

### Custom Node Testing

- [x] I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help)

### Expected Behavior

Modules using torch.nn.utils.parametrizations.weight_norm like Conv1d layers in AudioOobleckVAE should be properly loaded to GPU during novram

### Actual Behavior

weight-normalized modules are incorrectly skipped in _load_list(), causing:

RuntimeError: Input type (torch.cuda.HalfTensor) and weight type (torch.HalfTensor) should be the same

this affects the Stable Audio VAE and any other model using PyTorch's weight normalization parametrizations.

### Steps to Reproduce

1. Load stable-audio-open-1.0.safetensors
2. Run audio generation workflow with --novram
3. VAE decode fails with device mismatch error

### Debug Logs

```powershell
(salient logs shared above)
```

### Other

in stable audio, weight normalization stores weights as parametrizations.weight.original0 and parametrizations.weight.original1, which only appear in recurse=True so:

```py
for name, param in m.named_parameters(recurse=True):
if name not in params:
if not name.startswith("parametrizations."):
skip = True
break

```

```
parametrizations
```
is the intended misspelling and is correct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.