Comfy-Org / Comfy-Org/ComfyUI-Manager

API /manager/notice taking forever and blocking other async api

Open
#351 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16.1k
Forks
2.5k
Avg merge
5d 4h
Merged PRs (30d)
13

Description

## Background
- when I try to install cutsom nodes
![image](https://github.com/ltdrdata/ComfyUI-Manager/assets/67146986/0ab2e3f5-6e8b-4c37-89f5-c7e5b66d001d)

- several apis will be triggered, including */manager/notice* and **/customnodes/getlist**(this pending results in stuck at this waiting page ⬆️)
image

- OS: ubuntu22.04
- ComfyUI Commit: f2d432f9a754f2bacb85a70f7e2b817e6dba44f8(lastest master)
- ComfyUI-Managet Commit: e5a0a2e6587365a955e6a4e0f515a8fc346394fc(lastest main)
- ENV: set http_proxy and https_proxy to my proxy server at "http://127.0.0.1:7890"

## Problem
- I found that if I call */customnodes/getlist* alone, it has no problem at all
- if I call */manager/notice* alone, it will be pending like forever
- most importantly, while */manager/notice* is pending, I call */customnodes/getlist* will be pending this time

## Solution
- I commented out the code of function *get_notice* of file \_\_init\_\_.py
- make it return *web.Response(text="Unable to retrieve Notice", status=200)*
- solve my problem temporary

## Expectation
fix or explain why did I encouter with these problems (not familier with js or python server, maybe just my problem) thanks~
- why async apis will block each other
- why */manager/notice* took so long, it just GET the wiki page of the repo
- I tried to comment the call logic in js file, results in ComfyUI-Manager not showing up

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.