Comfy-Org / Comfy-Org/ComfyUI-Manager

Manual review request for flagged Comfy Registry node version

Open
#2,997 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16.1k
Forks
2.5k
Avg merge
5d 4h
Merged PRs (30d)
13

Description

https://discord.com/channels/1218270712402415686/1319770970868945057/1515777859048833155

https://registry.comfy.org/ja/publishers/ruminar/nodes/gm-image-saver

https://github.com/ruminar/ComfyUI-GMImageSaver

This subprocess call is intentional and required for the node's core functionality.

GM Image Saver pipes raw RGB image bytes from a ComfyUI IMAGE tensor to GraphicsMagick via stdin and writes a JPEG file.

It uses `subprocess.run` with `shell=False` and a list of arguments. User-controlled strings are not concatenated into a shell command. The executable is resolved with `shutil.which("gm")`, and `GM_PATH` / environment-variable-based executable selection has been removed in v0.1.1.

The node does not use subprocess for package installation, network access, or arbitrary command execution.

If this was flagged because of the GraphicsMagick subprocess call, I believe it is a false positive. Please let me know if there is a specific pattern I should change for Comfy Registry compliance.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the linked Comfy Registry node entry and the ComfyUI-GMImageSaver repository, starting with the described GraphicsMagick subprocess behavior and the referenced Discord discussion. Done means determining whether the flag is a false positive and identifying any specific Comfy Registry compliance change required.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.