Comfy-Org / Comfy-Org/ComfyUI-Manager

Using type to get nodes dependencies is a big problem when multiple custom nodes can have the same type.

Open
#2,666 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16.1k
Forks
2.5k
Avg merge
5d 4h
Merged PRs (30d)
13

Description

I'm trying to use the cm-cli to get the dependencies of a workflow
`python $ROOT/custom_nodes/ComfyUI-Manager/cm-cli.py deps-in-workflow --workflow $SCRIPT_ROOT/default_workflow.json --output $SCRIPT_ROOT/default_workflow_deps.json`

And there is a node of type: `SDXLPromptStyler` which is returning `https://github.com/regiellis/ComfyUI-SDXL-Adherence` as the node dep.. but actually it should be `https://github.com/twri/sdxl_prompt_styler` . Seems that both custom nodes have that type registered.

I think the code should use `properties.cnr_id` to get the custom node.

https://github.com/Comfy-Org/ComfyUI-Manager/blob/001adf19c97bea4e65f34d1eafe0fd0624cba434/glob/manager_core.py#L2843

Thanks

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.