Comfy-Org / Comfy-Org/ComfyUI-Manager

The get_client_ip function has a bug

Open
#2,375 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16.1k
Forks
2.5k
Avg merge
5d 4h
Merged PRs (30d)
13

Description

```python
def get_client_ip(request):
peername = request.transport.get_extra_info("peername")
if peername is not None:
host, port = peername
return host

return "unknown"
```

The variable `peername` sometimes returns a value like this ('127.0.0.1', 19260), and sometimes it returns like this ('::1', 28891, 0, 0), throwing an exception: "too many values ​​to unpack". My comfyui desktop is now unable to start normally.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.