Comfy-Org / Comfy-Org/Comfy-Desktop

Manager allows for localhost to call maanger endpoints and execute any custom node installation - anything we can do about that?

Open
#1,215 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
458
Forks
59
Avg merge
22h 18m
Merged PRs (30d)
45

Description

With desktop (standalone installs), if we can somehow make the electron app be the only way to make manager calls go through, that would be a massive security boon - otherwise, a website could attempt to execute known localhost comfy port stuff to install custom nodes/cause remote code execution due to the unsecure custom nodes (which may be of git origina and not part of custom node registry).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how the Electron app makes manager calls to the localhost Comfy port, including custom-node installation requests. Determine how a website can reach these endpoints and define a verified restriction that leaves the Electron app functional while preventing unauthorized manager actions and remote code execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.