Comcast / Comcast/vesper_legacy
Format of token does not include headers and claims
- Dominant language
- Go
- Stars
- 8
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
So I might be confused on what should happen but it seems that only the signature is included and not the header and claims all concatenated with periods. It looks like the last line in encodeWithSigner clearly does this where it has
```
// return the signature part of JWT ONLY
return fmt.Sprintf("%s", base64Encode(sig)), nil
```
but I would hex expected it to be more likek
```
// return the JWT
return fmt.Sprintf("%s.%s.%s", h,c,base64Encode(sig)), nil
```
Thoughts on what this should be?
Contributor guide
Research direction
Start at the encodeWithSigner entry point named in the issue and inspect how h, c, and sig are produced and how callers consume the returned value. Compare the result with the three-part JWT format described in the report, then verify the corrected behavior with appropriate Go tests; no file or test is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100