Comcast / Comcast/sirius

SiriusResult can only wrap subclasses of RuntimeException

Open
#8 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Scala
Stars
296
Forks
48
PR merge metrics
No merged PRs in 30d

Description

This might be overly restrictive, especially since (for example) IOException is not a subclass of RuntimeException. Is there a reason SiriusResult can't just wrap Exception? I get that RuntimeException is the superclass of unchecked exceptions, but it's not obvious to me if or why that would be relevant.

Contributor guide

Open the contributing guide

Research direction

Start by locating SiriusResult and inspecting how its current RuntimeException restriction is defined and used. Determine whether wrapping broader exceptions such as IOException is intended, then verify that the chosen behavior is covered and that existing exception handling remains consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
distributed-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.