Comcast / Comcast/sirius

Prohibit null RequestHandler

Open
#15 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
296
Forks
48
PR merge metrics
No merged PRs in 30d

Description

The SiriusFactory object should require that a non-null RequestHandler be passed to the createInstance method. That would catch the not-uncommon mistake of passing a null handler, which subsequently causes hard to debug errors.

Contributor guide

Open the contributing guide

Research direction

Start at the SiriusFactory.createInstance entry point and trace how the RequestHandler argument is currently handled. Add coverage showing that a null handler is rejected, then run the relevant test suite and confirm that non-null handlers still create instances successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
distributed-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.