Comcast / Comcast/react-data-grid

Add top and left to cell editor props back

Open
#2,664 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
7.7k
Forks
2.2k
Avg merge
1d 2h
Merged PRs (30d)
33

Description

## Use case
The top and left properties were removed (PR #2420) from CellEditorProps which is taking away an important functionality to have custom editor with portal rendered at the cell position. We want to have a custom editor that opens at (right below) the cell position. The top and left properties are useful in positioning the cell editor at desired location when editor is rendered with portal and possibly floating on/below the cell itself.

## Proposed solution
1. Add top and left back to CellEditorProps. OR
2. When creating editor with portal, use current cell as the portal target (instead of Body) if user does not provide their custom portal target.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.