Comcast / Comcast/pxscene-ui

Improve algorithm for detecting changes amongst child elements

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
4
Forks
6
PR merge metrics
No merged PRs in 30d

Description

px2react currently deletes all child elements and re-creates them if an update changes the number of child elements. This applies to both pxObject and pxComponent children. Needless to say, this is less than optimal and has the undesirable effect of causing child components to unmount and remount even though they remain otherwise unchanged.

We need to optimize this algorithm, possibly through the use of the 'id' attribute.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.