Comcast / Comcast/publicious

Remove overuse of done test callback

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Currently we use done during the tests in a number of places, instead change to use chai's throw. http://chaijs.com/api/bdd/#method_throw
This will allow us to check for expected errors vs unexpected errors.
Since almost all publish calls are sync, done is unnecessary.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.