Comcast / Comcast/publicious

Promise from unsubscribe & publish

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3
Forks
8
PR merge metrics
No merged PRs in 30d

Description

A promise returned from unsubscribe & publish would allow a mechanism to know when they're done, due to the setTimeout's that may occur during either call.

Fix memory leak in PubSub unsubscribe when implementing the promises.

From @bfolts:

With the setTimeout used in Channel::unsubscribe you may unsubscribe after you return a false and never remove the channel since the underlying operation is asynchronous.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.