Comcast / Comcast/plax

Max attempts ignored when guard exists

Open
#145 1 comment 0 reactions 1 assignee Claimed by @jsccast View on GitHub
bug
Dominant language
Go
Stars
8
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Example:

```YAML
spec:
phases:
phase1:
steps:
- pub:
chan: mother
payload:
make:
name: shell
type: cmd
config:
command: bash
- recv:
chan: mother
pattern:
success: true
- pub:
payload: |
echo '{"statuscode":200,"body":{"activities":1}}'
- recv:
chan: shell
attempts: 1
pattern:
statuscode: 200
body:
activities: "?activities"
guard: |
return bindings["?activities"] >= 2;
```

This test should fail (without timing out). Instead it hangs. If the guard is removed (and the `recv` body is altered to prevent a match), the test fails immediately as it should.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.