Comcast / Comcast/mamba

Enable module stability. Now can't use with Swift 5.3.2.

Open
#102 5 comments 0 reactions 1 assignee Claimed by @jonnybach View on GitHub
Dominant language
Swift
Stars
191
Forks
43
PR merge metrics
No merged PRs in 30d

Description

### Description

Currently, I can't include it with Swift 5.3.2.
Screenshot 2021-02-22 at 6 10 26 PM

Since Swift 5.1, Apple provide module stability feature in Xcode. This enables a framework to be able to be included in targets with newer Swift versions. But `BUILD_LIBRARY_FOR_DISTRIBUTION` build setting has to be enabled.
Screenshot 2021-02-22 at 5 59 38 PM

Screenshot 2021-02-22 at 5 53 34 PM

My current workaround is to add a Podfile `post_install` script to do so:
```
post_install do | installer |
installer.pods_project.targets.each do |target|
if target.name == 'mamba-iOS' || target.name == 'mamba-tvOS'
target.build_configurations.each do |config|
config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'YES'
end
end
end
end
```

### Tasks

- [ ] Set `BUILD_LIBRARY_FOR_DISTRIBUTION` build setting to `Yes`

### References

* https://swift.org/blog/library-evolution/

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.