Comcast / Comcast/jrugged

Should SystemClock be used internally?

Open
#35 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
268
Forks
95
PR merge metrics
No merged PRs in 30d

Description

Should all the uses of System.currentTimeMillis be replaced with SystemClock.currentTimeMillis? I would suppose the meaning of SystemClock is to allow tests to mock it up and simulate slow services and the like.

Of course, this would mean to allow each of the affected classes to receive a Clock as parameter. If not, the SystemClock is used.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.