Comcast / Comcast/gots

Proposal: Deprecation of non-receiver functions in packet package

Open
#98 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
310
Forks
88
PR merge metrics
No merged PRs in 30d

Description

Pull Request #92 moves to pointer receivers on the type Packet for interacting with the various fields of an mpeg TS packet. This creates duplicate functionality with functions that are already in place.
- Proposal: To create parity with the other packages we would like to move towards pointer receivers for all the functions that interact with packet. This means deprecating many of the current functions in packet.go

We would love input and guidance from the open source community on whether these are worthwhile changes. If this is decided to be a valuable change the old functions would be depreciated, and removed in a few months time.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.