Comcast / Comcast/gots

Reconcile the two versions of `adaptationfield.go`.

Open
#106 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
310
Forks
88
PR merge metrics
No merged PRs in 30d

Description

There are two files that deal with AdaptationFields:
- packet/adaptionfield.go: This one feels like the "right" one to use.
- packet/adaptationfield/adaptationfield.go: This one uses the older functional style.

I propose removing the `packet/adaptationfield/adaptationfield.go` file in favor of `packet/adaptationfield.go` as long as the functionality is the same and anything that is missing from `packet/adaptationfield.go` is filled in.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.