Comcast / Comcast/gots

packet: tests ignore errors in set up

Open
#101 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
310
Forks
88
PR merge metrics
No merged PRs in 30d

Description

In #97 I found that the test was failing got go1.9 or lower, but not above. I tracked this down to a failure of the set up to provide an non-empty input string because `hex.DecodeString` was given an odd-length string. The call to `hex.DecodeString` in the tests in "io_test.go" ignore the "error" returned allowing this kind of test corruption.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.