Col-E / Col-E/BentoFX

Fix NullAway/Error Prone warnings in `core`

Open
#49 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
49
Forks
6
PR merge metrics
No merged PRs in 30d

Description

This is a follow up issue that fixes issues were obscured by `doclint` warnings that were fixed in issues #45 and #47.

`NullAway/Error Prone` reports for multiple findings in `core`:
- Address a number of `==`/`!=` comparisons that compare object references instead of using `.equals()`/`Objects.equals()`.
- Address an `instanceof` pattern match against a field already declared as that exact type, which is equivalent to a plain null check.
- Address `@Nullable` fields that are dereferenced unconditionally.
- Address `StringSplitter` using a limit of `0`, which drops a trailing empty field.

Contributor guide

Open the contributing guide

Research direction

Start in the core module by running the NullAway/Error Prone reports and locating the listed reference comparisons, redundant instanceof check, nullable dereferences, and StringSplitter usage. Review the affected code and existing tests before changing it; done means the reported warnings are resolved and StringSplitter no longer drops a trailing empty field.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.