Cog-Creators / Cog-Creators/Red-DiscordBot

Consider mentioning case-sensitivity in error messages from Discord model converters

Open
#5,174 1 comment 0 reactions 0 assignees View on GitHub
Category: Core - API - Commands Package Category: Core - Other Internals Status: Needs Discussion Type: Enhancement
Dominant language
Python
Stars
5.7k
Forks
2.5k
Avg merge
6d 16h
Merged PRs (30d)
1

Description

### What component of Red (cog, command, API) would you like to see improvements on?

error messages

### Describe the enhancement you're suggesting.

Hi, I've mentioned in #3853 that it's a big UX issue that the role is not case insensitive. This issue also arises in other cogs/any command that uses a role.

I'd like to propose subclassing `RoleNotFound` from discord.py to mention the case-insensitivity, as that's the issue about 90% of the time when users see this error text. It could instead say:

```
Role {role} not found. Please note, roles are case-sensitive.
```

And this would be a much more useful error.

Thanks!

### Anything else?

I'm not sure if this would be an appropriate change to suggest upstream to d.py or not? I haven't opened an issue there, since I *think* this is a Red thing that role inputs are case sensitive?? But I'm really not sure. Any thoughts on this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.