Cog-Creators / Cog-Creators/Red-DiscordBot

`localwhitelist` and `localblacklist` can both be non-empty at the same time

Open
#4,001 0 comments 0 reactions 0 assignees View on GitHub
Category: Core - Bot Class Category: Core - Bot Commands Status: In Progress Type: Bug
Dominant language
Python
Stars
5.7k
Forks
2.5k
Avg merge
6d 16h
Merged PRs (30d)
1

Description

# Other bugs

Something I noticed when testing #3903 (but out of scope for it), removing last user from localwhitelist or clearing it makes the bot use the previously configured localblacklist as adding people to `localwhitelist` does not automatically clear `localblacklist`.

IMO, adding people to one of these lists when other isn't empty should prompt the user to clear the other before allowing the user to add people.

Edit: I forgot to add reproduction steps, here they are (Replace `You` with your username):

Pre-requirements: You can't be bot or guild owner
1. Run both `[p]localblacklist clear` and `[p]localwhitelist clear` if they're not already empty
2. Run `[p]localwhitelist add You`
3. Run `[p]localblacklist add You`
4. Run `[p]localwhitelist remove You` or `[p]localwhitelist clear`
5. You can't run commands anymore because there was a blacklist you didn't know about configured

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.