Codeinwp / Codeinwp/visualizer
Using , instead of . for decimal breaks the graphs
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- PHP
- Stars
- 108
- Forks
- 29
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
In the data, if you use ',' for decimals, the graphs will not work properly.
Some countries use ',' as a decimal point instead of '.', for that reason, we should try to accommodate that use case.
It might just be a matter of replacing them:
str_replace ( '10,45' , '.' , ',');
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how chart data is parsed before it reaches the graphs, using the decimal-comma case described in the issue as the reproduction. Identify the relevant input-handling entry point and any existing checks or tests; done means values such as 10,45 are accepted and rendered correctly without breaking dot-decimal input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100