Codeinwp / Codeinwp/optimole-wp

Limit image size breaking retina is confusing

Open
#787 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new feature
Dominant language
PHP
Stars
72
Forks
14
Avg merge
2d 9h
Merged PRs (30d)
15

Description

What problem does this address?

I couldn't understand why images on Codeinwp are not looking great and I have realised this is because retina is disabled. It was hard to detect because in fact, the setting was enabled, just that I noticed after in the fine print of limit image size, which is enabled by default now, that Retina doesn't work with that.

If that setting is coming on by default, I don't think anyone would read through the whole paragraph to see that retina images aren't working, considering they can just enable that before.

https://vertis.d.pr/i/F138SN

What is your proposed solution?

If we want to leave the settings by default as they are now, I suggest that when a user tries to enable retina we alert them that we disabled limit image size setting for that to work.

Also if the image size is disabled and the user enables it while retina is also active, we alert them that we need to disable retina, since those can't function together.

Basically don't let the user believe that they can enable both of them at the same time.

Will this feature require documentation? (Optional)

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the interaction described in the issue: enable Retina, then enable Limit image size, and observe the current settings behavior. The change is done when users are alerted that the settings cannot be enabled together and the conflicting setting is disabled as proposed.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.