Codeinwp / Codeinwp/optimole-wp
image scaling toggle is not affecting the retina visually despite they depend each other
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 72
- Forks
- 14
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 15
Description
Description
When scaling is disabled, the retina function becomes ineffective as it relies on the resizing script to determine whether the screen is retina. This limitation is expected.
However, the user interface does not currently indicate that disabling scaling also removes the retina functionality. We could consider marking the retina option as disabled and display a message when image scaling is turned off.
Step-by-step reproduction instructions
- Disable image scaling
- Enable retina
- Check that no dpr is added to the images
Screenshots, screen recording, code snippet or Help Scout ticket
No response
Environment info
No response
Is the issue you are reporting a regression
No
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the plugin settings by disabling image scaling and enabling retina, then locate the controls for these two options. Done means the retina option is visibly disabled or accompanied by a clear message when scaling is off, while the existing image behavior remains understandable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100