Codeinwp / Codeinwp/neve

No margin bottom for buttons in content with the WP editor

Open
#3,950 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
PHP
Stars
306
Forks
88
Avg merge
2d 16h
Merged PRs (30d)
12

Description

Description

A user mentioned on the forum that Neve doesn't add any margin to the buttons in the page content and that Gutenberg blocks should have a margin. I need help here as I don't know if it's a guideline in this regard or not.

What I did is to use the button block from WP and the buttons group block from Otter, and none of the allows the user to set a margin for the buttons. Compared to Neve, the Twenty Twenty-One theme seems to add margin to all the blockw within the page content with the * CSS selector.

Neve

neve-margin

Twenty Twenty-One

twentyone-margin

Step-by-step reproduction instructions
  1. Add a button from WordPress
  2. Add some content above and below it, like text
  3. Try adding some margin around the buttons - there is no such option; I didn't find it in the Otter Buttons Group block either.
Screenshots, screen recording, code snippet or Help Scout ticket

https://wordpress.org/support/topic/wp-block-button__link-should-have-margin/

Environment info

Not relevant for this case

Is the issue you are reporting a regression

No

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in WordPress using a Button block and an Otter Buttons Group block, then compare the resulting spacing with Twenty Twenty-One. Identify the theme styles responsible for content-block spacing; done means buttons have appropriate margin when surrounded by other content without requiring a separate margin control.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, php, wordpress
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.