Codeception / Codeception/module-yii2

2.0.0 silently dropped support for `grabFixture()` with numeric indices

Open
#145 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
19
Forks
43
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Codeception/module-yii2/commit/baba62281f6839e1c21e646d50971156fd7b8faa, a typing refactoring, changed the type of `grabFixture()` `$index` param to `string|null`.

Historically though, this could also be an integer (like, if you just have a fixture array _without_ keys) - see e.g. https://github.com/yiisoft/yii2-app-advanced/blob/8d10c0d2ff1c78c454cf649226ca8465a198902e/frontend/tests/Support/data/login_data.php .

Imho that support should not be dropped. And if that was intentional, it should be in CHANGELOG / release notes.

(yes, technically, using integers as string `'0'` might still work, but that's ugly)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.