Codeception / Codeception/module-phalcon4

Cookie not compatible with symfony/browser-kit

Open
#24 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
3
Forks
8
PR merge metrics
No merged PRs in 30d

Description

In the old version of `symfony/browser-kit`, the Cookie's `__construct` is

```
public function __construct(string $name, ?string $value, string $expires = null, string $path = null, string $domain = '', bool $secure = false, bool $httponly = true, bool $encodedValue = false, string $samesite = null) { ... }
```

And in the Phalcon4, using cookie set with `expires` is only allow integer, so there will be `TypeError` when running the test.

```
[TypeError] Argument 3 passed to Symfony\Component\BrowserKit\Cookie::__construct() must be of the type string or null, int given, called in /root/.composer/vendor/codeception/module-phalcon4/src/Codeception/Lib/Connector/Phalcon4.php on line 156
```

Maybe convert the timestamp to UTC String for old symfony/browser-kit?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.