Codeception / Codeception/module-laravel

The Issue with Null $wrap Property in resource API Calls

Open
#49 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
6
Forks
13
PR merge metrics
No merged PRs in 30d

Description

I have two APIs that when I call the first one, it returns a specific resource as shown below:
```php
class FirstResource extends JsonResource
{
public function toArray($request)
{
self::withoutWrapping();
return [
....
];
}
}
```
And the second API returns a resource as shown below:

```php
class SecondResource extends JsonResource
{
public function toArray($request)
{
return [
....
];
}
}
```

JsonResource code (Laravel source code):
```php
class JsonResource implements ArrayAccess, JsonSerializable, Responsable, UrlRoutable
{
/**
* The "data" wrapper that should be applied.
*
* @var string|null
*/
public static $wrap = 'data';
//...
}
```
The problem is that when these calls are made, the **`$wrap`** property in the second resource becomes null, even though its value should be equal to 'data', causing the test to fail.

Actually, the first resource affects the second resource on separate APIs!!!

Why it happens ?

I think Laravel-module makes just one instance of the app for all tests, so this conflict happens, am I right?

It can be fixed?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.