CodeGenieApp / CodeGenieApp/serverless-express

Headers and Body not being assigned to the ServerlessRequest in NodeJS v19.1.0

Open
#581 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5.3k
Forks
676
PR merge metrics
No merged PRs in 30d

Description

When making a request in NodeJS v19.1.0 the request headers and body don't get passed through correctly. After some debugging I've narrowed it down to this Object.assign in the request constructor: https://github.com/vendia/serverless-express/blob/mainline/src/request.js#L18

When making a request on Node v16.18.1 or v18.12.1 it's fine, but v19.1.0 it doesn't work, both the test header and all other headers aren't being assigned

16.18.1
NodeJS v16 18 1

18.12.1
NodeJS v18 12 1

19.1.0
NodeJS v19 1 0

Workaround is just to use NodeJS < 19 for now

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.