CodeForPhilly / CodeForPhilly/clean-and-green-philly
Task: Standardize Boolean handling in front end to match pipeline changes
- Dominant language
- Python
- Stars
- 50
- Forks
- 92
- PR merge metrics
- No merged PRs in 30d
Description
## Description
In the data pipeline, we've standardized the handling of Boolean values that were previously inconsistently formatted (sometimes as strings, sometimes as Booleans, and often with inconsistent nomenclature). As part of data quality control, these have been normalized to proper Boolean values. This will impact the formatting of the output data, so the front end needs to be updated to handle these changes.
(Note that not all of these fields are used in the FE--you'll have to figure out which ones are.)
**THIS ISSUE IS ON HOLD UNTIL THE NEW PIPELINE IS RUNNING AND NEW DATA HAVE BEEN PUSHED TO GCP.**
## Changes Made to Data Format
| Field | Old Format | New Format | Source File |
|-------|------------|------------|------------|
| unsafe_building | String ("Y"/"N") | Boolean (true/false) | unsafe_buildings.py |
| imm_dang_building | String ("Y"/"N") | Boolean (true/false) | imm_dang_buildings.py |
| tactical_urbanism | String ("Yes"/"No") | Boolean (true/false) | tactical_urbanism.py |
| conservatorship | String ("Yes"/"No") | Boolean (true/false) | conservatorship.py |
| is_actionable | String ("NA") | Boolean (true/false) | delinquencies.py |
| sheriff_sale | String ("Y"/"N") | Boolean (true/false) | delinquencies.py |
| payment_agreement | String ("NA") | Boolean (true/false) | delinquencies.py |
| side_yard_eligible | String ("Yes"/"No") | Boolean (true/false) | city_owned_properties.py |
## Acceptance Criteria
- [ ] Review all front end code that consumes the affected fields
- [ ] Update component logic to handle Boolean values instead of strings
- [ ] Update any display formatting that depends on the string values
- [ ] Update relevant tests to reflect the new data format
- [ ] Verify display is correct with new data format in development environment
Contributor guide
Assessment
This issue has not been assessed yet.