CodeForPhilly / CodeForPhilly/clean-and-green-philly

Task: Update the tests for the new ETL pipeline (feature-new-etl)

Open
#1,144 0 comments 0 reactions 0 assignees View on GitHub
backend python
Dominant language
Python
Stars
50
Forks
92
PR merge metrics
No merged PRs in 30d

Description

## Update the tests for test_diff_backup, test_vacant_properties and test_ppr_properties for the new ETL pipeline

Some existing tests work as is for the new ETL pipeline but `test_diff_backup.py`, `test_vacant_properties` and `test_ppr_properties` need additional changes.

## Acceptance Criteria

- [ ] DiffReport is tested
- [ ] vacant_properties or sub-components are tested

## Additional context

Previously `vacant_properties` didn't take any arguments, but now it is after `opa_properties` in the pipeline.
We may want to separate out testable sub-functions because the existing tests requires a lot of mocking which makes it less clear what is actually being verified.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.