CodeForPhilly / CodeForPhilly/clean-and-green-philly

Bug: Filters are ignored on first re-render of map on overlay change

Open
#1,131 0 comments 0 reactions 0 assignees View on GitHub
bug frontend
Dominant language
Python
Stars
50
Forks
92
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
With activate filters showing only a select number of properties on the map, any changes to the overlay to "streets", "dataviz", or "hybrid" visualization accessible in the top-left corner of the map will cause all the properties on the map to render with the switch, ignoring the active filters.

Subsequent changes to the filter then reapply them again, so that the visuals are correct.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to the filters panel and set a neighborhood filter such as "Allegheny West".
2. Click on the overlay button and switch to "dataviz".
4. See all the map properties re-rendered rather than just the selected filtered ones.

**Expected behavior**
Filters should be persistent across changes to the map visualization, and any switches between them should not affect the current properties being rendered on the map.

**Desktop (please complete the following information):**

- OS: Ubuntu 24.04.2
- Browser: Mozilla Firefox 136.0.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.