CodeEditApp / CodeEditApp/CodeEdit

✨ Pinch to increase/decrease font size

Open
#1,210 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Swift
Stars
23k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

### Description

We can do pinch-to-zoom, but it has to be smooth.

Perhaps we pinch and initially zoom during the gesture (not change the font size), then after the gesture ends, reset the zoom and adjust the font size to the same visual size when it was previously zoomed which would wrap the text as expected.

That would appear to the user like this:
1. Gesture (Pinch to zoom) starts
2. Gesture ends
3. Text immediately reflows to wrap

What actually happens:
1. Gesture (pinch-to-zoom) starts
2. Text view zoomed - remaining anchored to the left
3. Gesture ends
4. Zoom amount multiplier captured
5. Text view zoom restored
6. Font size is multiplied by the zoom amount multiplier previously captured
7. This gives the appearance of the text reflowing to wrap

This behavior can be seen when looking at the Find Navigator, doing a search, and resizing the navigator sidebar. Notice it doesn't reflow the text until releasing the mouse to commit the size.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.