CodeChain-io / CodeChain-io/foundry

The snapshot service must wait to join the child thread on exit

Open
#72 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
36
Forks
11
PR merge metrics
No merged PRs in 30d

Description

https://github.com/CodeChain-io/codechain/blob/18e1e80af4503cfd4d06e9514e9f88370995abda/sync/src/snapshot/service.rs#L72
Currently, the snapshot service spawns a thread to use the db but doesn't wait for the end of the child thread when it exit. It can corrupt the db.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.