CodeChain-io / CodeChain-io/foundry

Organize validator set

Open
#560 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
36
Forks
11
PR merge metrics
No merged PRs in 30d

Description

## Types

Eventually, we will have only 3 types for validators.

1. `ctypes::Validator` - It has two fields: `public_key` and `weight`.
2. `ctypes::ValidatorSet` - It is a newtype of `Vec`, but it save it sorted, and provides methods to save to/load from state. Also, its hash will be directly written in block header.
3. `foundry_graphql_engine::Validator` GraphQL resolver for validator.

All other types will be completely removed. (`NextValidatorSet`, `CurrentValidatorSet`, `SimpleValidator`, `WeightOrderedValidators`, ...)

## Naming

Validators -> Validator set
delegation/deposit/ ... -> weight

## Next / Current
Both will be saved, but share same type `ValidatorSet`.

## Coordinator-Module interface
Will be asked to return only `Vec` as the validator set.

## Test
We have to add various e2e tests that involve multiple nodes + varying validator set.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.