CodeChain-io / CodeChain-io/foundry

Separate out block_opened/closed() from TxOwner

Open
#555 0 comments 1 reaction 1 assignee Claimed by @dynaxis View on GitHub
Dominant language
Rust
Stars
36
Forks
11
PR merge metrics
No merged PRs in 30d

Description

We should separate out the block related methods from TxOwner in the following grounds:

1. Some modules not implementing any Tx may serve `TxOwner`s and may want to have chances to prepare to serve them and/or clean up after serving all.
2. Modules implementing multiple types of Txes may get notified on block open/close only once. With `TxOwner`s exported for all Tx types implemented by a module, all of the `TxOwner`s will be redundantly notified.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.