CodeChain-io / CodeChain-io/codechain

Timer cancellation is not reliable

Open
#1,780 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
256
Forks
50
PR merge metrics
No merged PRs in 30d

Description

We detect whether the timer was canceled in ad-hoc ways.
Especially, if a lock is involved, the situation is not desirable.
This commit addresses that: https://github.com/CodeChain-io/codechain/commit/96f7f942f3021b4154a5da14bbd7680c1e080200

We need a regular mechanism to know fired timeout is canceled, not by ad-hoc devised ways if we can't control it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.