ClusterLabs / ClusterLabs/resource-agents
usage of status action in OCF RAs needs clarifying or eliminating
- Dominant language
- Shell
- Stars
- 519
- Forks
- 608
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 7
Description
[Initially reported in [the wrong place](http://bugs.clusterlabs.org/show_bug.cgi?id=5271)]
https://github.com/ClusterLabs/resource-agents/blob/master/doc/dev-guides/ra-dev-guide.txt#L100 says that the `status` action is an "historical (deprecated) synonym for `monitor`".
However I am reliably informed that the status action has different semantics to the `monitor` action, and that "it's needed if you want your RA to serve as a heartbeat style resource which noone uses anymore, or as an init script (which noone uses anymore either), because possibly someone is still running them in a heartbeat-style environment somewhere".
I also note that most (all?) of the bundled OCF RAs still implement `status`, and differently to the `monitor` action, e.g.
- https://github.com/ClusterLabs/resource-agents/blob/master/heartbeat/IPaddr2#L1083
Even if there are people crazy enough to be still running ancient heartbeat environments (and I am sure there are), surely they wouldn't ever upgrade them to the latest versions from git `master`? (And if they did, that wouldn't be supported in any way.) So isn't it time just to drop this cruft from all RAs?
Even if there is a good reason to keep it which I'm missing, it would be good to have some more clarity in the RA dev guide about this. Thanks!
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with doc/dev-guides/ra-dev-guide.txt around the statement that status is a deprecated synonym for monitor, then compare the status implementation in heartbeat/IPaddr2. Establish the intended semantics and whether status should remain; done means the guide and affected OCF RAs consistently reflect the decided behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- documentation, infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100