ClusterLabs / ClusterLabs/fence-agents

Validate SSL certificate against CA_BUNDLE path

Open
#94 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
126
Forks
186
PR merge metrics
No merged PRs in 30d

Description

It is better than to not validate at all:

for python-suds (fence_vmware_soap):

http://docs.python-requests.org/en/master/user/advanced/
requests.get('https://github.com', verify='/path/to/certfile')

change in:
line 61 -- transport=RequestsTransport(verify=verify)

---------
for gnutls (SSL clients):

change will be required in fencing.py:
function _open_ssl_connection(options):

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the python-suds fence_vmware_soap code around line 61, where RequestsTransport is created, and then read fencing.py and _open_ssl_connection(options) for the gnutls SSL-client path. The issue is done when both paths use the supplied CA_BUNDLE path for certificate validation rather than leaving verification disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.