ClusterLabs / ClusterLabs/fence-agents
[azure_fence.py] Endpoint for Azure Germany is missing
- Dominant language
- Python
- Stars
- 125
- Forks
- 184
- PR merge metrics
- No merged PRs in 30d
Description
The Azure Germany URL endpoint is not defined in the corresponding function.
```
def get_azure_arm_endpoints(cloudName, authority):
cloudEnvironment = {
"authority_hosts": authority
}
if cloudName == "AZURE_CHINA_CLOUD":
cloudEnvironment["resource_manager"] = "https://management.chinacloudapi.cn/"
cloudEnvironment["credential_scopes"] = ["https://management.chinacloudapi.cn/.default"]
return cloudEnvironment
if cloudName == "AZURE_US_GOV_CLOUD":
cloudEnvironment["resource_manager"] = "https://management.usgovcloudapi.net/"
cloudEnvironment["credential_scopes"] = ["https://management.core.usgovcloudapi.net/.default"]
return cloudEnvironment
if cloudName == "AZURE_PUBLIC_CLOUD":
cloudEnvironment["resource_manager"] = "https://management.azure.com/"
cloudEnvironment["credential_scopes"] = ["https://management.azure.com/.default"]
return cloudEnvironment
```
According to Microsoft's documentation, it should be "https://management.microsoftazure.de/"
Control plane
https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/control-plane-and-data-plane#control-plane
Contributor guide
No contributing guide indexed for this repository
Research direction
Open azure_fence.py and inspect get_azure_arm_endpoints alongside the existing cloud-specific branches. Add the missing Azure Germany endpoint using the URL given in the issue, then verify that the function returns the expected resource manager endpoint and credential scope for that cloud.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, python
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100