ClusterLabs / ClusterLabs/crmsh
crmsh.log lack marker to distinguish user command from internal sub-commands
- Dominant language
- Python
- Stars
- 143
- Forks
- 96
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 16
Description
When executing a high-level composite crmsh command such as
`adm@161-1:~> sudo -E crm cluster health sbd --fix
`
crmsh automatically runs multiple hidden internal subcommands.
All INFO log lines for both the original user command and every auto-spawned internal subcommand are printed without any distinguishing marker.
```
adm@161-1:~> sudo tail -f /var/log/crmsh/crmsh.log
2026-06-17T18:57:45.317+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# cluster health sbd --fix
2026-06-17T18:57:47.112+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure show related:stonith
2026-06-17T18:57:47.306+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure show xml
2026-06-17T18:57:47.741+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure show related:stonith
2026-06-17T18:57:47.958+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure show xml
2026-06-17T18:57:49.827+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure get_property stonith-watchdog-timeout
2026-06-17T18:57:50.206+0800 161-1 crmsh.ui_context: INFO: crm(live/161-1)# configure get_property stonith-timeout
2026-06-17T18:57:50.318+0800 161-1 crmsh.utils: WARNING: "stonith-timeout" is deprecated, please consider using "fencing-timeout"
2026-06-17T18:57:51.487+0800 161-1 crmsh.utils: WARNING: "stonith-timeout" is deprecated, please consider using "fencing-timeout"
2026-06-17T18:57:51.529+0800 161-1 crmsh.utils: WARNING: "stonith-enabled" is deprecated, please consider using "fencing-enabled"
2026-06-17T18:57:51.535+0800 161-1 crmsh.sbd: INFO: SBD: Check sbd timeout configuration: OK.
```
Contributor guide
Research direction
Start by tracing how the user command and auto-spawned subcommands are logged in crmsh.ui_context, using the crmsh.log example as the behavioral reference. Review the related crmsh.utils and crmsh.sbd logging paths to understand whether the marker belongs at command dispatch or log formatting. Done means INFO entries distinguish the original command from internal subcommands without obscuring the command text.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100