Cloud-CV / Cloud-CV/EvalAI

Submission worker: Add successful_submission_flag==True condition before saving submission_output

Open
#2,373 5 comments 0 reactions 1 assignee Claimed by @KhalidRmb View on GitHub
Dominant language
Python
Stars
2k
Forks
984
Avg merge
2h 54m
Merged PRs (30d)
14

Description

- **Expected behaviour**:
If the submission evaluation is not succesful then the submission output in the database should not be updated.
_Example_: if the challenge splits in the output and the database don't match, this line should not run: https://github.com/Cloud-CV/EvalAI/blob/34cf4572d6938a5f16a4d97b1e8434ee5bb49d75/scripts/workers/submission_worker.py#L513
- **Observed behaviour**:
The submission output in the database is updated irrespective of the contents of the evaluated submission output.

@RishabhJain2018

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.