ClosedXML / ClosedXML/ClosedXML
Optionally pass through the `CultureInfo` instance in the `XLWorkbook` instance
Open
- Dominant language
- C#
- Stars
- 5.7k
- Forks
- 933
- Avg merge
- 12h 14m
- Merged PRs (30d)
- 1
Description
Follow-up to #1359
This relates to a comment I made somewhere in another PR. I think we should optionally pass through the `CultureInfo` instance in the `XLWorkbook` instance and use that everywhere where applicable. Default to `CurrentCulture`. We'll have to do a separate PR for that.
_Originally posted by @igitur in https://github.com/ClosedXML/ClosedXML/pull/1359/files_
Contributor guide
Research direction
Read issue #1359 and its referenced comment first, then inspect the XLWorkbook entry point and the culture-sensitive paths it reaches. Done means CultureInfo can be supplied optionally, defaults to CurrentCulture, and is used consistently wherever applicable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- internationalization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100