ClimateMind / ClimateMind/climatemind-backend
Refactor Feed & Score Nodes
- Dominant language
- Python
- Stars
- 24
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
### What to refactor?
- `app/scoring/score_nodes.py`
### Refactor reasons and solutions
- [ ] Score nodes presently use unconventional python naming with variables in ALL_CAPS format,
- [ ] has a few variables that are declared and never used
- [ ] does not use dependency injection as it should.
- [ ] it is only used by the feed but is located in the scoring folder so it should be relocated.
- [ ] Storing the climate feed into the db should not occur in this class.
- [ ] Feed uses some variables in ALL_CAPS, a generalized try/except to catch multiple types of errors,
- [ ] Imports are not in pep8 order & relative imports should be used when possible
- [ ] Both should use Pep 287 reST formatting for docstrings.
- [x] We're passing a quiz_uuid to a query for a session_uuid in the localized graph function and this is bad!
### Tests
- [ ] unit tests
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.