ClickHouse / ClickHouse/libhdfs3

StripedBlockUtil.cpp: Potential integer overflow

Open
#71 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
43
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Since int64_t StripedBlockUtil::getInternalBlockLengt returns int64_t
https://github.com/ClickHouse/libhdfs3/blob/d0ae7d2568151feef61d3ec7896803262f0e0f91/src/client/StripedBlockUtil.cpp#L117-L134
and only dataSize has int64_t

there could be integer overflow at:
https://github.com/ClickHouse/libhdfs3/blob/d0ae7d2568151feef61d3ec7896803262f0e0f91/src/client/StripedBlockUtil.cpp#L132-L134

Possible fix:
cast one of member of adddition to int64_t

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.