ClickHouse / ClickHouse/graphouse

Python drivers for graphite-web are not compatible with python 3

Open
#98 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
261
Forks
55
PR merge metrics
No merged PRs in 30d

Description

New version of graphite-web is now supporting python 3.
I ve tried to setup everything and i was unable to display any data.
After looking in the driver ( and spending some time , i'm not a python dev , so apology if the vocabulary is not correct ) , i 've found 2 blocking issue in graphouse.py
1: in the __init__ method of the graphouseReader, the way to detect if we have a collection or a string is not working ( hasattr(path, '__iter__') is returning true on string , so it breaks everything, using something like isinstance(obj, collections.Sequence) should solve the issue )
2 : The fetch method is now taking 5 parameters instead of 3 ( self, start,stop,now,requestContext).

By fixing those 2 issues , i was able to make things work. But as i ve starting to learn python during the troubleshooting i don't feel really confortable to propose a fix.

Regards

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.