ClickHouse / ClickHouse/dbt-clickhouse

Port our Jaffle-shop fork changes to the main repository

Open
#668 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
362
Forks
177
Avg merge
2d 10h
Merged PRs (30d)
8

Description

Our Jaffle shop fork: https://github.com/ClickHouse/jaffle-shop-clickhouse

View of all the changes: https://github.com/dbt-labs/jaffle-shop/compare/main...ClickHouse:jaffle-shop-clickhouse:main

### Pending things:

**From already existing PRs:**
- [ ] `clickhouse__cents_to_dollars` macro [https://github.com/dbt-labs/jaffle-shop/pull/117](https://github.com/dbt-labs/jaffle-shop/pull/117)
- [ ] Fix warnings with Fusion [https://github.com/dbt-labs/jaffle-shop/pull/106](https://github.com/dbt-labs/jaffle-shop/pull/106)
- [ ] Add the metricflow_time_spine.yml [https://github.com/dbt-labs/jaffle-shop/pull/118](https://github.com/dbt-labs/jaffle-shop/pull/118)

**PRs to add:**
- [ ] Couple of small fixes in dbt_project.yml to correctly parse seed's `opened_at`  column and to add `require_generic_test_arguments_propert: true` .
- [ ] Add alias to the columns used in `order_items.sql`  so instead of `order_items.*`  we add
```sql
order_items.order_item_id as order_item_id,
order_items.order_id as order_id,
order_items.product_id as product_id,
```

**Docs update**:
- [ ] Add docs about how to configure a local ClickHouse instance. We include a example of a docker-compose setup, it would be nice to have it. 
- [ ] Jaffle-shop mentions about running the project in dbt Cloud, that's a pending thing :3
- [ ] CI/CD instructions with ClickHouse details https://github.com/ClickHouse/jaffle-shop-clickhouse/pull/6.

**Other things**
- [ ] There's a bunch of dependencies that are updated by dependabot that may be interesting to upgrade as all of them are related to CVEs.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the ClickHouse fork with the main jaffle-shop repository and reviewing the linked PRs, dbt_project.yml, metricflow_time_spine.yml, and order_items.sql. Work through the checklist, including the configuration, SQL aliases, local ClickHouse Docker Compose documentation, dbt Cloud and CI/CD guidance, and dependency updates; done means the listed fork changes are represented in the main repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
clickhouse, docker-compose, sql, yaml
Domain
ci-cd, databases, documentation
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.