ClickHouse / ClickHouse/dbt-clickhouse
Fix usage of make_temp_relation and make_intermediate_relation macro functions
- Dominant language
- Python
- Stars
- 362
- Forks
- 177
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 8
Description
### Describe the bug
Looks like we are using them in the same way but we should be using `make_intermediate_relation` for all the situations where we need intermediate tables and actually `make_temp_relation` for the small number of situations where we actually need temporary tables.
For example we needed to copy `unit.sql` here https://github.com/ClickHouse/dbt-clickhouse/pull/515#pullrequestreview-3245836795 just to be able to mark the relation as temporary, but we shouldn't need to copy it if `make_temp_relation` were always used to create temporary relations.
Contributor guide
Research direction
Search the repository for all uses of make_temp_relation and make_intermediate_relation, then inspect unit.sql and the discussion in pull request 515 for context. Done means intermediate tables consistently use make_intermediate_relation, while only genuinely temporary tables use make_temp_relation, without needing a copied unit.sql.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clickhouse, python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100