ClickHouse / ClickHouse/clickhouse-rs

Include rows_before_limit_at_least in X-ClickHouse-Summary header

Open
#398 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
559
Forks
172
Avg merge
1d 19h
Merged PRs (30d)
3

Description

### Use case

I'm using fetch_bytes("RowBinaryWithNamesAndTypes") to get query results in binary format. I parse the binary response myself in Rust and use cursor.summary() (from #397) to get query statistics.

The problem is that rows_before_limit_at_least is only available when using JSON output formats (JSON, JSONStrings, etc.) because it's embedded in the JSON body. When using RowBinary, the only source of server-side stats is the X-ClickHouse-Summary HTTP header, which doesn't include this field.

### Describe the solution you'd like

Could rows_before_limit_at_least be added to the X-ClickHouse-Summary header, so that non-JSON format users can also access it?

Related #397

Contributor guide

Open the contributing guide

Research direction

Start by reading cursor.summary() from #397 and tracing how the X-ClickHouse-Summary header is handled for fetch_bytes("RowBinaryWithNamesAndTypes"). Check the existing summary-related behavior and tests, if present. Done means rows_before_limit_at_least is available through the summary for non-JSON responses.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.